misc: update rust-toolchain file to TOML format #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move rust-toolchain to rust-toolchain.toml 2. Update the parsing process of rust-toolchain in the test script. Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
adamqqqplay
requested review from
bergwolf,
power-more and
Desiki-high
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
- Coverage 62.73% 62.73% -0.01%
==========================================
Files 129 129
Lines 44158 44158
Branches 44158 44158
==========================================
- Hits 27703 27702 -1
Misses 15088 15088
- Partials 1367 1368 +1 |
|
Any benefit to using the toml? |
The main reason I submitted this PR was that Github Dependabot was unable to parse our legacy rust toolchain, which did not facilitate quick fixes for security vulnerabilities. The rust-toolchain file in TOML format has been supported in rustup 1.23.0, bringing some new features. You can refer to: https://blog.rust-lang.org/2020/11/27/Rustup-1.23 .0.html#new-format-for-rust-toolchain |
jiangliu
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Dependabot can't parse our rust-toolchain. Because only rust-toolchain files formatted as TOML are supported in Dependabot. And the non-TOML format was deprecated by Rust.
Details
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.